Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Close to the users #493

Merged
merged 1 commit into from
Apr 21, 2023
Merged

docs: Add Close to the users #493

merged 1 commit into from
Apr 21, 2023

Conversation

vtomasr5
Copy link
Contributor

Description

Add Close to the USERS.md

Fixes: <! -- link to issue -->

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

Signed-off-by: Vicens Juan Tomas <vtomasr5@gmail.com>
@werne2j
Copy link
Member

werne2j commented Apr 20, 2023

@vtomasr5 once you sign off you commit and the DCO passes we can merge this in. Thanks for adding your company!

@vtomasr5
Copy link
Contributor Author

Hi @werne2j
I already sign off the commit (via ammend) but the action did not get triggered again.

@codecov-commenter
Copy link

Codecov Report

Merging #493 (9ab7fca) into main (b587367) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   75.31%   75.31%           
=======================================
  Files          25       25           
  Lines        1689     1689           
=======================================
  Hits         1272     1272           
  Misses        323      323           
  Partials       94       94           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@werne2j werne2j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vtomasr5!

@werne2j werne2j merged commit 359a636 into argoproj-labs:main Apr 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants