Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update usage to be argocd-vault-plugin #56

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Feb 8, 2021

Description

Update usage from argocd-vault to argocd-vault-plugin

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been
  • Docs have been added / updated

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@werne2j werne2j self-assigned this Feb 8, 2021
@werne2j werne2j requested a review from jkayani as a code owner February 8, 2021 15:39
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #56 (947e348) into main (5fe0e85) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   44.73%   44.73%           
=======================================
  Files          13       13           
  Lines         427      427           
=======================================
  Hits          191      191           
  Misses        213      213           
  Partials       23       23           
Impacted Files Coverage Δ
cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe0e85...0cc323b. Read the comment docs.

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct: the binary is published with the name argocd-vault-plugin

Nothing should break in terms of functionality, since this is just the usage message

@werne2j werne2j merged commit d59a2de into main Feb 8, 2021
@werne2j werne2j deleted the updateUpdage branch February 8, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants