Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #561

Merged
merged 2 commits into from Nov 5, 2023
Merged

chore: Replace deprecated command with environment file #561

merged 2 commits into from Nov 5, 2023

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Sep 29, 2023

Description

Update .github/workflows/release.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo ::set-output name=tag::${GITHUB_REF#refs/*/}

TO-BE

run: echo "tag=${GITHUB_REF#refs/*/}" >> $GITHUB_OUTPUT

Fixes #560

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

None

@codecov-commenter
Copy link

Codecov Report

Merging #561 (0e13467) into main (c4e125b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files          26       26           
  Lines        1953     1953           
=======================================
  Hits         1393     1393           
  Misses        460      460           
  Partials      100      100           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@werne2j werne2j merged commit d32f531 into argoproj-labs:main Nov 5, 2023
3 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch November 6, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
3 participants