Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go version to 1.21 #565

Merged
merged 1 commit into from Oct 20, 2023
Merged

chore: update go version to 1.21 #565

merged 1 commit into from Oct 20, 2023

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Oct 15, 2023

Description

Update go version to 1.21

Fixes:
https://github.com/argoproj-labs/argocd-vault-plugin/security/dependabot/37 & https://github.com/argoproj-labs/argocd-vault-plugin/security/dependabot/36

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Merging #565 (e67a3b7) into main (5084eca) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   71.29%   71.29%           
=======================================
  Files          26       26           
  Lines        1951     1951           
=======================================
  Hits         1391     1391           
  Misses        460      460           
  Partials      100      100           
Files Coverage Δ
cmd/util.go 76.92% <100.00%> (ø)
pkg/auth/vault/kubernetes.go 64.70% <100.00%> (ø)
pkg/utils/util.go 59.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -7,7 +7,7 @@ quality:
go test -race -v -coverprofile cover.out ./...

build:
go build -o ${BINARY} .
go build -buildvcs=false -o ${BINARY} .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just 1 question

@werne2j werne2j merged commit 6f4a0f5 into main Oct 20, 2023
3 checks passed
@werne2j werne2j deleted the go1.21 branch October 20, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants