Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plumbing: resolve non-external delta references #7

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

rohankmr414
Copy link
Collaborator

In a self-contained pack file delta references might point to base objects stored later in the file.
In this case we need to replace placeholders for external refs with the actual base object and update the children references.

Fixes: argoproj/argo-workflows#10225

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

In a self-contained pack file delta references might point to base
objects stored later in the file.
In this case we need to replace placeholders for external refs with the
actual base object and update the children references.

Fixes: go-git#484

Co-authored-by: Markus Wolf <mail@markus-wolf.de>
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
@sarabala1979 sarabala1979 merged commit 75279d8 into argoproj-labs:master Jan 14, 2023
@rohankmr414 rohankmr414 deleted the ref-delta branch January 14, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git artifacts: 'reference delta not found' clone problem
4 participants