Support passing Hera Parameter/ModelParameter as dictionary input to tasks #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviuvadan
added
semver:patch
elliotgunton
requested changes
Jan 19, 2024
|
May I suggest a test or two? 👀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
=====================================
Coverage 81.5% 81.6%
=====================================
Files 52 52
Lines 4091 4098 +7
Branches 851 854 +3
=====================================
+ Hits 3337 3344 +7
Misses 562 562
Partials 192 192 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
January 22, 2024 16:44
Merge queue setting changed
Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
…uments input Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
* Argument Parameters should take the dict key as its name, rather than the Parameter/ModelParameter's name * Add tests Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
elliotgunton
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
.valueonParameters passed toarguments#923See #923