fix: Improve linting/editor experience for hera models. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCardin
requested review from
flaviuvadan,
samj1912 and
elliotgunton
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=====================================
Coverage 81.5% 81.5%
=====================================
Files 52 52
Lines 4079 4091 +12
Branches 851 851
=====================================
+ Hits 3325 3337 +12
Misses 562 562
Partials 192 192 ☔ View full report in Codecov by Sentry. |
DanCardin
commented
Jan 31, 2024
| @@ -7,7 +7,7 @@ | |||
| from typing import Any, Callable, Dict, List, Optional, Type, TypeVar, Union | |||
|
|
|||
| from hera.auth import TokenGenerator | |||
| from hera.shared._pydantic import BaseModel, root_validator | |||
| from hera.shared._pydantic import BaseModel, get_fields, root_validator | |||
There was a problem hiding this comment.
this get_fields thing I did mainly to avoid littering all the existing raw usages of __fields__ with # type: ignore because there's version specific linter error I was seeming to get.
Signed-off-by: DanCardin <ddcardin@gmail.com>
DanCardin
force-pushed
the
dc/improve-model-type-checking
branch
from
f5a1a85
to
b5f0c8e
Compare
|
The failing py3.8 build gives me no logs, so i wonder if it's actually a transient CI issue? And the coverage changes, I think are lies. There should be net no line coverage difference, as far as I can tell. |
samj1912
added
semver:patch
samj1912
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Today, hera models seem to receive no editor/linter support for the
__init__arguments of hera models.This seems to be solely from the necessary try/except imports used to support both pydantic v1 and v2. Both mypy and pyright will bail on and not yield useful types when you do this. But it can be hacked around with some more conditionals imports 😅
Today:
With this change:
