Add template_level_volume example #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
elliotgunton
commented
Feb 6, 2024
elliotgunton
commented
- Upstream example but only appears in docs so is not part of the usual collection
- User in slack was asking how to recreate this example, see https://cloud-native.slack.com/archives/C03NRMD9KPY/p1707226500216859
elliotgunton
added
semver:patch
elliotgunton
force-pushed
the
add-template-level-volume-example
branch
from
eee5ac1
to
f9b6904
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 52 52
Lines 4098 4098
Branches 854 854
=====================================
+ Hits 3344 3346 +2
+ Misses 562 560 -2
Partials 192 192 ☔ View full report in Codecov by Sentry. |
elliotgunton
force-pushed
the
add-template-level-volume-example
branch
2 times, most recently
from
f898617
to
eee5ac1
Compare
* Upstream example but only appears in docs so is not part of the usual collection * User in slack was asking how to recreate this example Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
elliotgunton
force-pushed
the
add-template-level-volume-example
branch
from
eee5ac1
to
966f8ec
Compare
flaviuvadan
reviewed
Feb 8, 2024
| \ name: data\n spec:\n storageClassName: ssd\n accessModes:\ | ||
| \ [\"ReadWriteOnce\"]\n resources:\n requests:\n \ | ||
| \ storage: 1Gi" | ||
| manifest: |2- |
There was a problem hiding this comment.
For my own learning - does this magic |2- have a special meaning?
There was a problem hiding this comment.
Nevermind, this explains it
flaviuvadan
approved these changes
Feb 8, 2024
samj1912
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.