feat: return update errors (#55)

* Return update errors Signed-off-by: Tommy Chen <tommy351@gmail.com> * Remove unnecessary error logs Signed-off-by: Tommy Chen <tommy351@gmail.com> --------- Signed-off-by: Tommy Chen <tommy351@gmail.com>
argoproj-labs · Apr 29, 2024 · 783225b · 783225b
1 parent 47954c2
commit 783225b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/pkg/plugin/httproute.go b/pkg/plugin/httproute.go
@@ -56,8 +56,9 @@ func (r *RpcPlugin) setHTTPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight
 		r.UpdatedHTTPRouteMock = updatedHTTPRoute
 	}
 	if err != nil {
-		msg := fmt.Sprintf(GatewayAPIUpdateError, httpRoute.GetName(), err)
-		r.LogCtx.Error(msg)
+		return pluginTypes.RpcError{
+			ErrorString: err.Error(),
+		}
 	}
 	return pluginTypes.RpcError{}
 }

diff --git a/pkg/plugin/tcproute.go b/pkg/plugin/tcproute.go
@@ -3,7 +3,6 @@ package plugin
 import (
 	"context"
 	"errors"
-	"fmt"
 
 	"github.com/argoproj/argo-rollouts/pkg/apis/rollouts/v1alpha1"
 	pluginTypes "github.com/argoproj/argo-rollouts/utils/plugin/types"
@@ -50,8 +49,9 @@ func (r *RpcPlugin) setTCPRouteWeight(rollout *v1alpha1.Rollout, desiredWeight i
 		r.UpdatedTCPRouteMock = updatedTCPRoute
 	}
 	if err != nil {
-		msg := fmt.Sprintf(GatewayAPIUpdateError, tcpRoute.GetName(), err)
-		r.LogCtx.Error(msg)
+		return pluginTypes.RpcError{
+			ErrorString: err.Error(),
+		}
 	}
 	return pluginTypes.RpcError{}
 }