Add pass_credentials to argocd_application.spec.source.helm (#271)

Co-authored-by: OneMatchFox <878612+onematchfox@users.noreply.github.com>
argoproj-labs · May 4, 2023 · 8e40130 · 8e40130
1 parent fa86a9b
commit 8e40130
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 5 deletions.
diff --git a/argocd/resource_argocd_application_test.go b/argocd/resource_argocd_application_test.go
@@ -1127,6 +1127,8 @@ resource "argocd_application" "helm" {
           value = "standalone"
         }
 
+        pass_credentials = true
+
         value_files = ["values.yaml"]
 
         values = <<EOT

diff --git a/argocd/schema_application.go b/argocd/schema_application.go
@@ -1350,6 +1350,11 @@ func applicationSpecSchemaV4() *schema.Schema {
 											Description: "Whether to skip custom resource definition installation step (Helm's [--skip-crds](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/)).",
 											Optional:    true,
 										},
+										"pass_credentials": {
+											Type:        schema.TypeBool,
+											Description: "If true then adds --pass-credentials to Helm commands to pass credentials to all domains",
+											Optional:    true,
+										},
 									},
 								},
 							},

diff --git a/argocd/structure_application.go b/argocd/structure_application.go
@@ -272,6 +272,10 @@ func expandApplicationSourceHelm(in []interface{}) *application.ApplicationSourc
 		result.ReleaseName = v.(string)
 	}
 
+	if v, ok := a["pass_credentials"]; ok {
+		result.PassCredentials = v.(bool)
+	}
+
 	if parameters, ok := a["parameter"]; ok {
 		for _, _p := range parameters.(*schema.Set).List() {
 			p := _p.(map[string]interface{})
@@ -744,11 +748,12 @@ func flattenApplicationSourceHelm(as []*application.ApplicationSourceHelm) (
 			}
 
 			result = append(result, map[string]interface{}{
-				"parameter":    parameters,
-				"release_name": a.ReleaseName,
-				"skip_crds":    a.SkipCrds,
-				"value_files":  a.ValueFiles,
-				"values":       a.Values,
+				"parameter":        parameters,
+				"release_name":     a.ReleaseName,
+				"skip_crds":        a.SkipCrds,
+				"value_files":      a.ValueFiles,
+				"values":           a.Values,
+				"pass_credentials": a.PassCredentials,
 			})
 		}
 	}

diff --git a/docs/resources/application.md b/docs/resources/application.md
@@ -258,6 +258,7 @@ Optional:
 Optional:
 
 - `parameter` (Block Set) Helm parameters which are passed to the helm template command upon manifest generation. (see [below for nested schema](#nestedblock--spec--source--helm--parameter))
+- `pass_credentials` (Boolean) If true then adds --pass-credentials to Helm commands to pass credentials to all domains
 - `release_name` (String) Helm release name. If omitted it will use the application name.
 - `skip_crds` (Boolean) Whether to skip custom resource definition installation step (Helm's [--skip-crds](https://helm.sh/docs/chart_best_practices/custom_resource_definitions/)).
 - `value_files` (List of String) List of Helm value files to use when generating a template.