Add support for timezone in sync window #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmcnair
force-pushed
the
add-support-for-timezone-in-sync-window
branch
from
a13724b
to
033d501
Compare
jsmcnair
force-pushed
the
add-support-for-timezone-in-sync-window
branch
from
033d501
to
3ee7e84
Compare
onematchfox
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
LGTM.
FYI:
- fixed some indentations issues in the tests (mixture of tabs/spaces is painful)
- cherry-picked a couple of fixes for flaky tests from Implement provider using
terraform-plugin-frameworkand upgrade to TF Plugin Protocol Version V6 #301
With more and more tests, these tests are starting to become very flaky as tokens have expired by the time the Terraform test framework does a post-apply refresh on the test steps.
onematchfox
force-pushed
the
add-support-for-timezone-in-sync-window
branch
from
62dfb2b
to
d411750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the ArgoCD API now supports setting the timezone in a project's sync window, the provider does not expose this so I have had to set it manually. This change exposes the timezone capability in the provider so that it can be configured via Terraform.