Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Use updated Application CRD ( apiextensions/v1beta1 to v1 ) #145

Closed
sbose78 opened this issue Mar 3, 2021 · 2 comments
Closed

Use updated Application CRD ( apiextensions/v1beta1 to v1 ) #145

sbose78 opened this issue Mar 3, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbose78
Copy link
Contributor

sbose78 commented Mar 3, 2021

after argoproj/argo-cd#5516 is merged.

Creating this issue as an FYI though I wouldn't expect any change in how the Golang dependency is consumed.

@sbose78 sbose78 changed the title Use Application "v1" API Use updated Application CRD ( apiextensions/v1beta1 to v1 ) Mar 3, 2021
@jgwest jgwest added the enhancement New feature or request label Mar 4, 2021
@jgwest jgwest added this to the 0.1.0 - Milestone 1 milestone Mar 5, 2021
@jgwest
Copy link
Member

jgwest commented Mar 9, 2021

Thanks @sbose78, ApplicationSet controller switched to non-beta v1 version with #128, and I've confirmed that Argo CD's switch does not affect our functionality.

I've swapped the integrated Argo CD + ApplicationSet controller install YAML to Argo CD's master branch (eg what will become v1.9.0, as there isn't a v1.9 tag/branch yet), and everything works as expected there. (It will officially swap on release of ApplicationSet controller v0.1.0.)

So we should be good to go, absent any additional issues found during testing.

@jgwest jgwest self-assigned this Mar 9, 2021
@jgwest jgwest closed this as completed Mar 11, 2021
@sbose78
Copy link
Contributor Author

sbose78 commented Mar 11, 2021

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants