This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Use apiextensions.k8s.io/v1 CustomResourceDefinition, rather than deprecated v1beta1 #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v1beta1 CRD definition is deprecated since Kubernetes v1.16, and is causing issues with the Helm chart linting, also described here.
This PR:
metadata
fields of a template, in generated CRD resource:k8s.io/apimachinery/pkg/apis/meta/v1
, it is not included in the OpenAPI CRD schema.apiextensions.k8s.io/v1
then k8s APIServer doesn't recognize this field as a valid metadata field (outside of it's use at the root). When you try to create an ApplicationSet with.spec.template.metadata
fields (for example, from kubectl), the APIserver ignores the values.Fixes #127