Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Remove workaround for Argo CD issue 5817 'Unable to delete an Application if its target cluster is deleted' #175

Open
jgwest opened this issue Mar 29, 2021 · 1 comment
Open

Remove workaround for Argo CD issue 5817 'Unable to delete an Application if its target cluster is deleted' #175

jgwest opened this issue Mar 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jgwest
Copy link
Member

jgwest commented Mar 29, 2021

PR #171 and issue #170 introduced a workaround for argoproj/argo-cd#5817.

We should remove this workaround from the ApplicationSet codebase when this issue has been fixed in all supported versions of Argo CD.

As of this writing (Mar 29, 2021), we still support Argo CD v1.8.x with ApplicationSet controller, so presuming this is fixed in v2.0.x, this workaround would be removed after either:

  • We drop support for v1.8.x.
  • Or we adopt the fix in v1.8.x (less likely, given that v1.8.x may potentially only be limited to only high severity fixes)
@jgwest jgwest added the enhancement New feature or request label Mar 29, 2021
@jgwest jgwest added this to the Milestone 2 milestone Mar 29, 2021
@jgwest jgwest mentioned this issue Mar 29, 2021
Merged
@jgwest jgwest removed this from the Milestone 2 milestone Apr 21, 2021
@jgwest
Copy link
Member Author

jgwest commented Jul 6, 2021

I've confirmed that the Argo CD PR argoproj/argo-cd#6557 fixes the issues we were seeing on cluster secret deletion; but we will need to wait for people to move off unpatched versions of Argo CD before we remove the workaround here.

@jgwest jgwest mentioned this issue Jul 29, 2021
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgwest