This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Workaround Argo CD cluster deletion reconciliation bug #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need unit tests, or can we really on the E2E tests? |
OmerKahani
reviewed
Mar 26, 2021
OmerKahani
reviewed
Mar 26, 2021
OmerKahani
suggested changes
Mar 26, 2021
|
Thanks @OmerKahani , I've updated the PR with your requested changes, and add unit tests for the new method. If you can take a look ASAP that would be great, as I'd like to update the RC driver with this change so it can be tested. Thanks 😄 ! |
OmerKahani
approved these changes
Mar 27, 2021
Looks great now! |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Application finalizer if the cluster destination for that Application is detected to be is invalid (for example, the cluster was removed from Argo CD, or the cluster secret was deleted). This ensures that the Application can be deleted successfully without locking up the Argo CD instance (See the parent issue for details on Argo CD's bad behaviour).
Since the cluster destination does not exist, there are no application resources to clean up, so we are safe to remove the finalizer (but until the upstream bug is fixed in supported Argo CD versions, we need to workaround it here).
Fixes #170