Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Kustomize integration of Application Set controller and Argo CD (#87) #113

Merged
merged 1 commit into from Feb 5, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Feb 2, 2021

This PR inserts new code into the generation script, to automatically render a YAML file containing

  • the ApplicationSet k8s resources
  • the latest stable Argo CD k8s resources (stable is latest stable release, currently '1.8.3'). This is the same URL that Argo CD references for installation in its docs, and should thus be durable.

together into a file manifests/install-with-argo-cd.yaml

I went with install-with-argo-cd.yaml as the name, if folks have a better name suggestion let me know!

To install both Argo CD and ApplicationSets, together, all one needs to do is:

kubectl install -f manifests/install-with-argo-cd.yaml

(equivalent to this section of Argo CD)

This is an alternative to the standalone Application Set install, which is kubectl install -f manifests/install.yaml

Steps for how to use this file will be added to the Installation section of the docs, as part of the existing 'user guide' issues.

Fixes #87

@jgwest jgwest marked this pull request as ready for review February 2, 2021 21:10
@jgwest jgwest requested a review from wtam2018 February 2, 2021 21:19
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jgwest

@jgwest jgwest merged commit db51ff1 into argoproj:master Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomize integration of Application Set controller and Argo CD
2 participants