Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Kustomize Argo CD integration (and GitHub E2E test action) should use a fixed Argo CD version #119

Merged
merged 3 commits into from Feb 11, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Feb 9, 2021

This PR adds a check to manifest generation (via hack/verify-argo-cd-versions.sh), which verifies that all locations that reference Argo CD are consistent with a single Argo CD target version.

This also:

  • Updates to latest Argo CD v1.8.4
  • Slightly cleans up ci-build.yaml and adds a new k3s-version for backwards compatibility testing (since I'm editing the file anyway)

Fixes #118

@jgwest jgwest changed the title Kustomize Argo CD integration (and GitHub E2E test action) should use a fixed Argo CD version (#118) Kustomize Argo CD integration (and GitHub E2E test action) should use a fixed Argo CD version Feb 9, 2021
@jgwest jgwest marked this pull request as ready for review February 9, 2021 04:46
@jgwest jgwest requested a review from wtam2018 February 9, 2021 04:46
@wtam2018 wtam2018 self-requested a review February 11, 2021 19:47
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @jgwest

@jgwest jgwest merged commit 1fbaaf0 into argoproj:master Feb 11, 2021
@jgwest jgwest deleted the argo-cd-kustomize-version-118 branch June 7, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomize Argo CD integration (and GitHub E2E test action) should use a fixed Argo CD version
2 participants