Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Prevent ApplicationSet controller from creating invalid Applications, causing 'unable to delete application resource' in Argo CD #136

Merged
merged 1 commit into from Mar 1, 2021
Merged

Prevent ApplicationSet controller from creating invalid Applications, causing 'unable to delete application resource' in Argo CD #136

merged 1 commit into from Mar 1, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Feb 25, 2021

Fixes #112

This PR:

  • Use the Argo CD "github.com/argoproj/argo-cd/util/argo" package's ValidateDestination and ValidatePermissions to verify generated application validity
  • Adds unit tests to verify some of the desired validations

@jgwest
Prevent ApplicationSet controller from creating invalid Applications,…
bfb5174 
… causing 'unable to delete application resource' in Argo CD
@jgwest jgwest marked this pull request as ready for review February 25, 2021 11:44
@jgwest jgwest requested a review from wtam2018 February 25, 2021 11:44
@jgwest jgwest merged commit f72bf48 into argoproj:master Mar 1, 2021
@jgwest jgwest mentioned this pull request Mar 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OmerKahani OmerKahani OmerKahani approved these changes

@wtam2018 wtam2018 Awaiting requested review from wtam2018

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jgwest @OmerKahani