Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

'Error generating params' error when using JSON array in Git files generator file #139

Merged
merged 2 commits into from Mar 2, 2021
Merged

'Error generating params' error when using JSON array in Git files generator file #139

merged 2 commits into from Mar 2, 2021

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Mar 1, 2021 •
edited

Fixes #107

See comments on parent issue for details.

@jgwest jgwest marked this pull request as ready for review March 1, 2021 18:51
wtam2018
wtam2018 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@wtam2018 wtam2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jgwest Thanks!
I think we should document the behavior in user's doc.

@jgwest jgwest mentioned this pull request Mar 2, 2021
Closed
@jgwest
Copy link
Member Author

jgwest commented Mar 2, 2021

Thanks William 👍 , I've opened #142 to cover this.

@jgwest jgwest merged commit 075397f into argoproj:master Mar 2, 2021
@jgwest jgwest deleted the support-json-array-107 branch April 20, 2021 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wtam2018 wtam2018 wtam2018 approved these changes

@OmerKahani OmerKahani Awaiting requested review from OmerKahani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Error generating params' error when using JSON array in Git files generator file
2 participants
@jgwest @wtam2018