This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Applicationset-controller overloads api-server and have memory leak #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
This was caused by our creating a SettingsManager (SettingsManager in settings.go in Argo CD) with every call of the ClusterGenerator. Since the settings manager contains a client and 2 listers, each instance was opening sockets and multiple goroutines to handle resource caching with the k8s server. The socket and these connections were what were occupying the leaked memory:
The fix is: