This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Annotations set in application-set not updating apps #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
The fix for this bug is the change to
createOrUpdateInClusterinpkg/controllers/applicationset_controller.go, everything else in this PR is test updates to ensure the correctness of the fix (for both unit and E2E tests).The bug occurred because:
createOrUpdateInClusterwas not copying metadata fields.c.Get(...)inCreateOrUpdate(...)increateOrUpdate.gowas not replacing the existing fields of the Application parameter that was passed in, causing the objects to appear equal (when they were not). Fix is to pass in a preinitializedargov1alpha1.Application{}value intoutils.CreateOrUpdate(...). (It's unclear whether this is only an issue with the fakeclient, or a general problem, but in any case this is the fix.)