This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Improve and document the developer deployment process. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoodness
suggested changes
Sep 4, 2020
Rather than require developers to change on disk files in the git index, or create custom patching solutions, introduce a make target that allows us to build, push, and deploy manifests in a single command.
dgoodwin
force-pushed
the
dev-deploys
branch
from
7f60273
to
af2f5ac
Compare
|
PR updated, thanks! |
xianlubird
approved these changes
Sep 14, 2020
mgoodness
pushed a commit
to mgoodness/applicationset
that referenced
this pull request
Sep 14, 2020
Rather than require developers to change on disk files in the git index, or create custom patching solutions, introduce a make target that allows us to build, push, and deploy manifests in a single command.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than require developers to change on disk files in the git index,
or create custom patching solutions, introduce a make target that allows
us to build, push, and deploy manifests in a single command.
Adds namespace to the ServiceAccount subject in the ClusterRoleBinding,
as far as I can tell this was invalid yaml.