This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
add sync status #48
Merged
add sync status #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls fix the conflict |
Closed
|
Are we confident exposing this as a global setting on the CLI isn't going to get picked up by someone and used beyond what we'd like? This really should be in the generator spec as you mentioned. Doing it across the whole controller is definitely not something we'd want to live for very long. |
xianlubird
approved these changes
Sep 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to determine the sync status. When using the git generator, a user can cause an application to be deleted by changing the name of the folder. This PR aimed to give an option to prevent delete / update in the reconcile.
It's should probably be part of the generator metadata, but for now, we can start with a global flag.
Based on the policies from external-dns