Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Add template override #56

Merged
merged 7 commits into from Jan 22, 2021
Merged

Conversation

OmerKahani
Copy link
Contributor

fix #27

@OmerKahani OmerKahani changed the title [WIP] add template override Add template override Jan 2, 2021
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OmerKahani, looks great, just a couple suggestions, let me know what you think.

pkg/generators/interface.go Show resolved Hide resolved
examples/template-override.yaml Show resolved Hide resolved
pkg/controllers/applicationset_controller.go Outdated Show resolved Hide resolved
Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgwest jgwest merged commit e0ff409 into argoproj:master Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Template Override
2 participants