Add git directory generator

[OmerKahani]

closes #12

[dgoodwin]

Looks pretty good to me, but I am not familiar with the use of the argo git repo apiclient yet.

[rtnpro]

What's the status with this pull request? Can I lend a hand here? cc @OmerKahani @dgoodwin

[OmerKahani]

Hi @rtnpro, I stopped working on it because of #12 , give me a few more days to implement the solution and push it.
And then I could use your help, thanks for patience

[dgoodwin]

This is great, I had hoped to test but having some troubles just getting the appset controller running now.

[dgoodwin]

Could I get a peek at the repo and ApplicationSet you're using for testing? I'm having some trouble getting this to work. After adding ConfigMap RBAC locally I keep getting no results from the g.repos.GetApps call:

time="2020-09-08T11:35:26Z" level=info msg="applications result from the repo service" allAps="[]" repoURL="https://github.com/dgoodwin/kube-gitops-apps.git" revision=master total=0

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: gitdirgen
spec:
  generators:
  - git:
      repoURL: https://github.com/dgoodwin/kube-gitops-apps.git
      revision: master
      directories:
      - path: generators/git/dirs/*
  template:
    metadata:
      name: '{{path.basename}}'
    spec:
      project: ""
      source:
        repoURL: https://github.com/dgoodwin/kube-gitops-apps.git
        targetRevision: HEAD
        path: '{{path}}'
      destination:
        server: SNIP
        namespace: kube-system

[OmerKahani]

Could I get a peek at the repo and ApplicationSet you're using for testing? I'm having some trouble getting this to work. After adding ConfigMap RBAC locally I keep getting no results from the g.repos.GetApps call:

time="2020-09-08T11:35:26Z" level=info msg="applications result from the repo service" allAps="[]" repoURL="https://github.com/dgoodwin/kube-gitops-apps.git" revision=master total=0

apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
metadata:
  name: gitdirgen
spec:
  generators:
  - git:
      repoURL: https://github.com/dgoodwin/kube-gitops-apps.git
      revision: master
      directories:
      - path: generators/git/dirs/*
  template:
    metadata:
      name: '{{path.basename}}'
    spec:
      project: ""
      source:
        repoURL: https://github.com/dgoodwin/kube-gitops-apps.git
        targetRevision: HEAD
        path: '{{path}}'
      destination:
        server: SNIP
        namespace: kube-system

I am using an helm application. ListApp only support helm / Ksonnet / Kustomize :(
https://github.com/argoproj/argo-cd/blob/aa2762a9b70edcc55756d20466a2dea21b2344b6/util/app/discovery/discovery.go#L11

[dgoodwin]

Ahhh that is unfortunate. I will file an issue, it seems like something we should eventually try to support given the spec document.

[dgoodwin]

Great work.