Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9723): off positioned filter icon #10013

Merged
merged 1 commit into from Jul 20, 2022

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Jul 16, 2022

Fixes #9723

Signed-off-by: Mayursinh Sarvaiya marvinduff97@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Screenshot 2022-07-11 at 12 09 59 PM (2)

Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com>
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #10013 (71d8d57) into master (a2a6d9d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10013   +/-   ##
=======================================
  Coverage   45.96%   45.96%           
=======================================
  Files         227      227           
  Lines       27279    27279           
=======================================
  Hits        12538    12538           
  Misses      13039    13039           
  Partials     1702     1702           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a6d9d...71d8d57. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit 5c08527 into argoproj:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter image is shifted too far to the left
2 participants