New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: server-side manifest generation for local diff (#8145) #10019
feat: server-side manifest generation for local diff (#8145) #10019
Conversation
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #10019 +/- ##
==========================================
- Coverage 46.25% 46.09% -0.16%
==========================================
Files 228 229 +1
Lines 27883 28140 +257
==========================================
+ Hits 12897 12972 +75
- Misses 13247 13404 +157
- Partials 1739 1764 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
3b13990
to
1ca3f48
Compare
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
da61afe
to
6bd57d2
Compare
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
fd9b8d3
to
f42d09b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky stuff. This looks awesome!
…arning Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
96bed5b
to
87dd512
Compare
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
87dd512
to
9f5837f
Compare
@notfromstatefarm can you resolve that conflict? |
@notfromstatefarm apologies for the slow review, can you resolve conflicts again? :-) |
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
6091385
to
e4232a6
Compare
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
@crenshaw-dev I thiiiiink that's a flake in |
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I think we need a follow-up issue because --local .
is going to cause the RelativePath()
check to fail. But otherwise, local testing checks out.
@crenshaw-dev @notfromstatefarm please, what release is this in? I've installed the latest release and can't find the changes in this yet |
@MeNsaaH it will be in 2.5 (RC1 coming in the next 2 weeks). |
Okay. Thank you @crenshaw-dev . |
Hi. Is this issue: agocd app diff failing with the URL scheme 'secrets' is not allowed still hasn't been solved in any argocd release? |
Signed-off-by: notfromstatefarm 86763948+notfromstatefarm@users.noreply.github.com
Closes #8145
This implements diffs of local manifests without having config management tools or CMPs locally installed, by streaming manifests from the CLI to the repo-server for manifest generation.
Adds:
--server-side-generate
parameter toargocd app diff
--local-include
It also refactors a little bit of the CMP stream for DRYness since that stream and this stream shares functionality.
Demo showing server-side diff and local diff being identical: