Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve docs/user-guide/kustomize.md #10025

Merged
merged 2 commits into from Jul 20, 2022
Merged

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 18, 2022

improve kustomize.md

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: xin.li <xin.li@daocloud.io>
@ashutosh16
Copy link
Contributor

@my-git9 Thanks for opening PR. Can you update the title to docs. Refer the guidelines to update the title
https://argo-cd.readthedocs.io/en/stable/developer-guide/toolchain-guide/#title-of-the-pr

@my-git9 my-git9 changed the title improve kustomize docs: improve kustomize Jul 19, 2022
@my-git9 my-git9 changed the title docs: improve kustomize docs: improve docs/user-guide/kustomize.md Jul 19, 2022
@my-git9
Copy link
Member Author

my-git9 commented Jul 19, 2022

@my-git9 Thanks for opening PR. Can you update the title to docs. Refer the guidelines to update the title https://argo-cd.readthedocs.io/en/stable/developer-guide/toolchain-guide/#title-of-the-pr

Updated

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 20, 2022 19:53
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #10025 (08a5ae3) into master (0b5b4a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10025   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files         227      227           
  Lines       27353    27353           
=======================================
  Hits        12555    12555           
  Misses      13095    13095           
  Partials     1703     1703           
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5b4a8...08a5ae3. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit dfe60a5 into argoproj:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants