Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy claims before modifying for logs #10044

Merged
merged 1 commit into from Jul 19, 2022

Conversation

notfromstatefarm
Copy link
Contributor

@notfromstatefarm notfromstatefarm commented Jul 19, 2022

Fixes changes introduced in #9947 which caused groups to be deleted from claims

Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 19, 2022 17:40
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #10044 (b0a182b) into master (708906d) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #10044      +/-   ##
==========================================
- Coverage   45.96%   45.89%   -0.07%     
==========================================
  Files         227      227              
  Lines       27279    27327      +48     
==========================================
+ Hits        12538    12541       +3     
- Misses      13039    13084      +45     
  Partials     1702     1702              
Impacted Files Coverage Δ
util/grpc/logging.go 58.33% <100.00%> (ø)
util/grpc/useragent.go 45.83% <0.00%> (-10.42%) ⬇️
server/rbacpolicy/rbacpolicy.go 82.35% <0.00%> (-2.43%) ⬇️
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <0.00%> (+2.55%) ⬆️
server/logout/logout.go 84.37% <0.00%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708906d...b0a182b. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit bb7c71c into argoproj:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants