feat: argocd app delete apps by label #10118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.70% // Head: 45.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10118 +/- ##
==========================================
- Coverage 45.70% 45.66% -0.04%
==========================================
Files 236 236
Lines 28668 28690 +22
==========================================
Hits 13102 13102
- Misses 13772 13794 +22
Partials 1794 1794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
requested changes
Aug 8, 2022
|
@danielhelfand if you resolve conflicts, I'll be happy to merge! |
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Thanks again for looking everything over. I have resolved the conflicts. |
crenshaw-dev
requested changes
Oct 1, 2022
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
crenshaw-dev
approved these changes
Oct 1, 2022
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* feat: argocd app delete apps by label Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: add path to e2e test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: use guestbook path in e2e test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: change operation status assertions in e2e test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: change sync status to synced Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: assert on cli output for err in e2e test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: assert on err not output in e2e test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: ignore error to allow assertion to take place in test Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: assert on Contains instead of Equal Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: swtich args to assert.Contains Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: selector and args should not be used together Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: add app to delete example Signed-off-by: Daniel Helfand <helfand.4@gmail.com> * fix: return err instead of nil Signed-off-by: Daniel Helfand <helfand.4@gmail.com> Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10091
Allow
argocd app deletecommand to delete apps having a common label. UX isargocd app delete -l foo=bar. Similar toargocd app sync -lexperience.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: