Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#9963): Add logic to handle for f.Close() for util/gpg #10130

Merged
merged 1 commit into from Jul 28, 2022

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Jul 28, 2022

the link issue: #9963

Add logic to handle for f.Close() for util/gpg

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: xin.li <xin.li@daocloud.io>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) July 28, 2022 14:17
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #10130 (da98962) into master (e3940cd) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #10130      +/-   ##
==========================================
- Coverage   45.88%   45.87%   -0.01%     
==========================================
  Files         227      227              
  Lines       27373    27385      +12     
==========================================
+ Hits        12560    12564       +4     
- Misses      13109    13113       +4     
- Partials     1704     1708       +4     
Impacted Files Coverage Δ
util/gpg/gpg.go 66.96% <50.00%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3940cd...da98962. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit 57a407e into argoproj:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants