Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude docs from Sonar check completely #10142

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

Looks like the current exclusions don't apply to the "bugs" check.

Signed-off-by: CI <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #10142 (c00cb05) into master (470176b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10142   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         227      227           
  Lines       27403    27403           
=======================================
  Hits        12584    12584           
  Misses      13110    13110           
  Partials     1709     1709           
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470176b...c00cb05. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit 4be0d41 into argoproj:master Jul 30, 2022
@crenshaw-dev crenshaw-dev deleted the exclude-docs-from-sonar-completely branch August 1, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants