feat: Added health check for spot.io SpotDeployment #10152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Leinov <dleinov@netapp.com>
Signed-off-by: Daniel Leinov <dleinov@netapp.com>
dleinov
force-pushed
the
spot-health-check
branch
from
1df23ca
to
373e01a
Compare
Signed-off-by: Daniel Leinov <dleinov@netapp.com>
ashutosh16
reviewed
Aug 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #10152 +/- ##
=======================================
Coverage 45.92% 45.92%
=======================================
Files 227 227
Lines 27403 27403
=======================================
Hits 12584 12584
Misses 13110 13110
Partials 1709 1709
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
crenshaw-dev
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
lgtm, will merge once @ashutosh16's question is answered/resolved.
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Aug 11, 2022
* feat: Added health check for spot.io SpotDeployment Signed-off-by: Daniel Leinov <dleinov@netapp.com> * feat: Added fixed SpotDeployment health check Signed-off-by: Daniel Leinov <dleinov@netapp.com> * feat: Added fixed SpotDeployment health check script Signed-off-by: Daniel Leinov <dleinov@netapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.