Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sarif upload categories #10171

Merged
merged 1 commit into from Aug 3, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

I validated that the category is being pulled from the sarif file instead of the GitHub workflow option. #10170

As far as I can tell, there's no way to ask the Snyk CLI to use a different automation ID. So I had to manually override the ID.

If this works, I'll put up a PR against the GitHub action to improve the error message.

Signed-off-by: CI <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #10171 (9e378db) into master (15ac1a6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10171   +/-   ##
=======================================
  Coverage   45.92%   45.92%           
=======================================
  Files         227      227           
  Lines       27403    27403           
=======================================
  Hits        12584    12584           
  Misses      13110    13110           
  Partials     1709     1709           
Impacted Files Coverage Δ
util/settings/settings.go 50.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ac1a6...9e378db. Read the comment docs.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit ee08c7b into argoproj:master Aug 3, 2022
@crenshaw-dev crenshaw-dev deleted the fix-sarif-upload-categories branch August 3, 2022 18:52
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
Signed-off-by: CI <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants