Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Golang to 1.19 (#10176) #10186

Merged
merged 5 commits into from Aug 5, 2022
Merged

chore: Upgrade Golang to 1.19 (#10176) #10186

merged 5 commits into from Aug 5, 2022

Conversation

omarkalloush
Copy link
Contributor

@omarkalloush omarkalloush commented Aug 3, 2022

Signed-off-by: OmarKalloush omar.kalloush@optimumpartners.co

Closes #10176

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #10186 (c2e1629) into master (15ac1a6) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master   #10186   +/-   ##
=======================================
  Coverage   45.92%   45.93%           
=======================================
  Files         227      227           
  Lines       27403    27419   +16     
=======================================
+ Hits        12584    12594   +10     
- Misses      13110    13114    +4     
- Partials     1709     1711    +2     
Impacted Files Coverage Δ
pkg/apiclient/apiclient.go 0.96% <0.00%> (ø)
cmd/util/app.go 52.38% <66.66%> (ø)
cmd/util/cluster.go 41.17% <66.66%> (ø)
reposerver/repository/repository.go 64.30% <87.50%> (ø)
cmd/argocd/commands/admin/settings_rbac.go 23.80% <100.00%> (ø)
util/git/creds.go 40.64% <0.00%> (-0.54%) ⬇️
util/helm/cmd.go 25.00% <0.00%> (-0.30%) ⬇️
util/settings/settings.go 50.90% <0.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <0.00%> (ø)
applicationset/generators/matrix.go 72.97% <0.00%> (+0.37%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crenshaw-dev crenshaw-dev changed the title Closes [#10176] Upgrade Golang to 1.19 chore: Upgrade Golang to 1.19 (#10176) Aug 3, 2022
@crenshaw-dev
Copy link
Collaborator

Failures look like:

  1. ioutil stuff has to be upgraded and
  2. make codegen

You up for that @omarkalloush? Let me know if you need any guidance!

@omarkalloush
Copy link
Contributor Author

@crenshaw-dev I'll give it a go 👍🏻

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
@crenshaw-dev crenshaw-dev merged commit ce394dd into argoproj:master Aug 5, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
* Upgrade Golang to 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* go mod tidy with go 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Replace deprecated ioutil

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* make codegen changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Codegen Changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>
crenshaw-dev pushed a commit to crenshaw-dev/argo-cd that referenced this pull request Jan 18, 2023
* Upgrade Golang to 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* go mod tidy with go 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Replace deprecated ioutil

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* make codegen changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Codegen Changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

chore: upgrade golangci-lint to 1.50.1

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

missed a spot

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

tidy

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

fix bad merge

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Author:    Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-Authored-By: OmarKalloush <omar.kalloush@optimumpartners.co>

fix indentation

fix lint and codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this pull request Feb 17, 2023
* chore: Upgrade Golang to 1.19 (#10176) (#10186)

* Upgrade Golang to 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* go mod tidy with go 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Replace deprecated ioutil

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* make codegen changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Codegen Changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

chore: upgrade golangci-lint to 1.50.1

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

missed a spot

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

tidy

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

fix bad merge

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Author:    Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-Authored-By: OmarKalloush <omar.kalloush@optimumpartners.co>

fix indentation

fix lint and codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* 1.20

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix lint errors

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix "syntax error: unexpected var after top level declaration" in "make test-race-local"

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: OmarKalloush <100078273+OmarKalloush@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* chore: Upgrade Golang to 1.19 (argoproj#10176) (argoproj#10186)

* Upgrade Golang to 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* go mod tidy with go 1.19

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Replace deprecated ioutil

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* make codegen changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

* Codegen Changes

Signed-off-by: OmarKalloush <omar.kalloush@optimumpartners.co>

chore: upgrade golangci-lint to 1.50.1

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

missed a spot

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

tidy

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

fix bad merge

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Author:    Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-Authored-By: OmarKalloush <omar.kalloush@optimumpartners.co>

fix indentation

fix lint and codegen

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* 1.20

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix lint errors

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix "syntax error: unexpected var after top level declaration" in "make test-race-local"

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: OmarKalloush <100078273+OmarKalloush@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to go 1.19
2 participants