Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup remnants of snyk scan removal #10225

Merged
merged 1 commit into from Aug 8, 2022

Conversation

34fathombelow
Copy link
Member

Signed-off-by: Justin Marquis 34fathombelow@protonmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #10225 (e4b4143) into master (84bb996) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10225   +/-   ##
=======================================
  Coverage   45.93%   45.93%           
=======================================
  Files         227      227           
  Lines       27434    27434           
=======================================
  Hits        12603    12603           
  Misses      13118    13118           
  Partials     1713     1713           
Impacted Files Coverage Δ
util/settings/settings.go 51.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@34fathombelow
Copy link
Member Author

34fathombelow commented Aug 7, 2022

@crenshaw-dev @jannfis Can you PTAL, quick fix for failing image workflow on push

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit c0f16fb into argoproj:master Aug 8, 2022
@crenshaw-dev
Copy link
Collaborator

Thanks @34fathombelow!

@34fathombelow 34fathombelow deleted the snyk-remnants branch August 8, 2022 16:25
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants