Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Google PubSub Topic and Subscription health checks #10229

Merged
merged 2 commits into from Aug 8, 2022
Merged

feat: Added Google PubSub Topic and Subscription health checks #10229

merged 2 commits into from Aug 8, 2022

Conversation

Kerwood
Copy link
Contributor

@Kerwood Kerwood commented Aug 6, 2022

Signed-off-by: Patrick Kerwood patrick@kerwood.dk

Added two new health checks for GKE Config Connector.

  • pubsub.cnrm.cloud.google.com
    • PubSubTopic
    • PubSubSubscription

Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>
Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #10229 (348726c) into master (84bb996) will increase coverage by 0.04%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##           master   #10229      +/-   ##
==========================================
+ Coverage   45.93%   45.98%   +0.04%     
==========================================
  Files         227      226       -1     
  Lines       27434    27413      -21     
==========================================
+ Hits        12603    12605       +2     
+ Misses      13118    13094      -24     
- Partials     1713     1714       +1     
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 20.44% <0.00%> (-0.06%) ⬇️
controller/sync.go 56.09% <ø> (ø)
util/argo/managedfields/managed_fields.go 67.27% <ø> (+25.22%) ⬆️
controller/state.go 73.89% <33.33%> (-0.33%) ⬇️
util/argo/diff/diff.go 52.41% <60.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kerwood!

@crenshaw-dev crenshaw-dev merged commit c317d48 into argoproj:master Aug 8, 2022
@Kerwood Kerwood deleted the feature/pubsub-health-checks branch August 8, 2022 18:50
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
…roj#10229)

* feat: Added Google PubSub Topic and Subscription to health checks

Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>

* Fixed apiVersion in test files

Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants