New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Gitlab PR generator webhooks support #10235
Conversation
fb580db
to
e9cafbd
Compare
Codecov Report
@@ Coverage Diff @@
## master #10235 +/- ##
==========================================
+ Coverage 45.93% 46.18% +0.24%
==========================================
Files 227 226 -1
Lines 27434 27579 +145
==========================================
+ Hits 12603 12737 +134
- Misses 13118 13122 +4
- Partials 1713 1720 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
e9cafbd
to
2010ac1
Compare
Tested manually on my own cluster. Works well. |
958f8e6
to
289c6aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect! One nitpick, plus, would you mind compressing the image? squoosh.app gets it down to 60kb from 600kb if I save it as a JPEG (which I think is fine for this use case).
Signed-off-by: vlad-boroda <enity.w@gmail.com>
289c6aa
to
a069a0f
Compare
Picture is now 111kb, i kept it png just for consistency. Don't know why but all pictures is png. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Enity!
Signed-off-by: vlad-boroda <enity.w@gmail.com>
Closes #10234
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: