Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gitlab PR generator webhooks support #10235

Merged
merged 1 commit into from Aug 8, 2022

Conversation

Enity
Copy link
Contributor

@Enity Enity commented Aug 7, 2022

Closes #10234

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@Enity Enity force-pushed the gitlab-pr-webhooks branch 2 times, most recently from fb580db to e9cafbd Compare August 7, 2022 17:43
@Enity Enity marked this pull request as ready for review August 7, 2022 17:47
@Enity Enity changed the title feat: add Gitlab PR generator webhooks support (#10234) feat: add Gitlab PR generator webhooks support Aug 7, 2022
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #10235 (a069a0f) into master (84bb996) will increase coverage by 0.24%.
The diff coverage is 52.45%.

@@            Coverage Diff             @@
##           master   #10235      +/-   ##
==========================================
+ Coverage   45.93%   46.18%   +0.24%     
==========================================
  Files         227      226       -1     
  Lines       27434    27579     +145     
==========================================
+ Hits        12603    12737     +134     
- Misses      13118    13122       +4     
- Partials     1713     1720       +7     
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 20.44% <0.00%> (-0.06%) ⬇️
controller/sync.go 55.33% <0.00%> (-0.77%) ⬇️
util/argo/managedfields/managed_fields.go 67.27% <ø> (+25.22%) ⬆️
controller/state.go 73.89% <33.33%> (-0.33%) ⬇️
applicationset/utils/webhook.go 73.29% <58.13%> (-0.94%) ⬇️
util/argo/diff/diff.go 52.41% <60.00%> (+0.20%) ⬆️
applicationset/utils/map.go 60.86% <0.00%> (-2.77%) ⬇️
applicationset/generators/matrix.go 70.73% <0.00%> (-2.25%) ⬇️
applicationset/generators/merge.go 59.04% <0.00%> (-1.96%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Enity
Copy link
Contributor Author

Enity commented Aug 7, 2022

Tested manually on my own cluster. Works well.
Docker image from this PR: https://hub.docker.com/r/enity/argocd-gitlab-mr-hooks

@Enity Enity force-pushed the gitlab-pr-webhooks branch 2 times, most recently from 958f8e6 to 289c6aa Compare August 7, 2022 20:53
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! One nitpick, plus, would you mind compressing the image? squoosh.app gets it down to 60kb from 600kb if I save it as a JPEG (which I think is fine for this use case).

applicationset/utils/webhook.go Outdated Show resolved Hide resolved
Signed-off-by: vlad-boroda <enity.w@gmail.com>
@Enity
Copy link
Contributor Author

Enity commented Aug 8, 2022

Almost perfect! One nitpick, plus, would you mind compressing the image? squoosh.app gets it down to 60kb from 600kb if I save it as a JPEG (which I think is fine for this use case).

Picture is now 111kb, i kept it png just for consistency. Don't know why but all pictures is png.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Enity!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) August 8, 2022 19:41
@crenshaw-dev crenshaw-dev merged commit 0baf485 into argoproj:master Aug 8, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
Signed-off-by: vlad-boroda <enity.w@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApplicationSet Gitlab PR generator hooks support
2 participants