New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: revert appset path.path and path.segments docs #10254
Conversation
Signed-off-by: CI <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #10254 +/- ##
=======================================
Coverage 46.18% 46.18%
=======================================
Files 226 226
Lines 27581 27581
=======================================
Hits 12737 12737
Misses 13124 13124
Partials 1720 1720
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ah yes I remember, I did this change and finally we added a dedicated section for GoTemplate. However I did not rollback changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me.
Thank you @speedfl! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be missing as well: https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/applicationset/Generators-Git.md?plain=1#L48
Good catch, fixed! |
* docs: revert appset path.path and path.segments docs Signed-off-by: CI <michael@crenshaw.dev> * more Signed-off-by: CI <michael@crenshaw.dev>
I think the find/replace when just slightly too far in #10026.
@speedfl could you take a look and confirm that this reversion is correct?