Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trim white space from string slice retrieved from environment #10275

Merged
merged 4 commits into from Aug 11, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Aug 11, 2022

See #10270 (comment)

Also, while at this module, I took a shot at the unit tests for util/env, homogenizing them and add tests for StringFromEnv() and StringsFromEnv() functions.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #10275 (c98f40c) into master (5515cde) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #10275      +/-   ##
==========================================
+ Coverage   46.10%   46.13%   +0.03%     
==========================================
  Files         228      228              
  Lines       27958    27960       +2     
==========================================
+ Hits        12889    12900      +11     
+ Misses      13322    13314       -8     
+ Partials     1747     1746       -1     
Impacted Files Coverage Δ
util/env/env.go 100.00% <100.00%> (+13.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

util/env/env.go Outdated Show resolved Hide resolved
util/env/env.go Outdated Show resolved Hide resolved
Signed-off-by: jannfis <jann@mistrust.net>
Copy link
Contributor

@notfromstatefarm notfromstatefarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) August 11, 2022 15:31
@crenshaw-dev crenshaw-dev merged commit b52098f into argoproj:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants