New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove unused plugin config fields #10304
Merged
crenshaw-dev
merged 2 commits into
argoproj:master
from
crenshaw-dev:remove-unused-plugin-config-fields
Oct 7, 2022
Merged
docs: remove unused plugin config fields #10304
crenshaw-dev
merged 2 commits into
argoproj:master
from
crenshaw-dev:remove-unused-plugin-config-fields
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CI <michael@crenshaw.dev>
crenshaw-dev
added
the
cherry-pick/2.4
Candidate for cherry picking into the 2.4 release branch
label
Aug 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #10304 +/- ##
==========================================
- Coverage 46.13% 46.13% -0.01%
==========================================
Files 228 228
Lines 27960 27961 +1
==========================================
Hits 12900 12900
- Misses 13314 13315 +1
Partials 1746 1746
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: CI <michael@crenshaw.dev>
ashutosh16
approved these changes
Aug 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexmt
approved these changes
Oct 7, 2022
crenshaw-dev
added a commit
that referenced
this pull request
Oct 7, 2022
* docs: remove unused plugin config fields Signed-off-by: CI <michael@crenshaw.dev> * fix codegen Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: CI <michael@crenshaw.dev>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 8, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
nirsht
pushed a commit
to nirsht/argo-cd
that referenced
this pull request
Oct 8, 2022
* docs: remove unused plugin config fields Signed-off-by: CI <michael@crenshaw.dev> * fix codegen Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields aren't used in code, so they shouldn't be in documentation.