Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused plugin config fields #10304

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

@crenshaw-dev crenshaw-dev commented Aug 12, 2022

These fields aren't used in code, so they shouldn't be in documentation.

Signed-off-by: CI <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Aug 12, 2022
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #10304 (d8642fd) into master (b38ff17) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10304      +/-   ##
==========================================
- Coverage   46.13%   46.13%   -0.01%     
==========================================
  Files         228      228              
  Lines       27960    27961       +1     
==========================================
  Hits        12900    12900              
- Misses      13314    13315       +1     
  Partials     1746     1746              
Impacted Files Coverage Δ
cmpserver/plugin/config.go 29.16% <ø> (ø)
pkg/apis/application/v1alpha1/types.go 54.84% <ø> (ø)
applicationset/services/repo_service.go 56.25% <0.00%> (-0.90%) ⬇️
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: CI <michael@crenshaw.dev>
Copy link
Contributor

@ashutosh16 ashutosh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 441b583 into argoproj:master Oct 7, 2022
@crenshaw-dev crenshaw-dev deleted the remove-unused-plugin-config-fields branch October 7, 2022 23:42
crenshaw-dev added a commit that referenced this pull request Oct 7, 2022
* docs: remove unused plugin config fields

Signed-off-by: CI <michael@crenshaw.dev>

* fix codegen

Signed-off-by: CI <michael@crenshaw.dev>

Signed-off-by: CI <michael@crenshaw.dev>
crenshaw-dev added a commit that referenced this pull request Oct 8, 2022
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
nirsht pushed a commit to nirsht/argo-cd that referenced this pull request Oct 8, 2022
* docs: remove unused plugin config fields

Signed-off-by: CI <michael@crenshaw.dev>

* fix codegen

Signed-off-by: CI <michael@crenshaw.dev>

Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Nir Shtein <89006520+nirsht@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch cherry-pick/2.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants