Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update K3s version matrix in e2e tests #10313

Merged
merged 1 commit into from Aug 12, 2022

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Aug 12, 2022

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #10313 (d2a440c) into master (b0bb52a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10313   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files         228      228           
  Lines       27961    27961           
=======================================
  Hits        12900    12900           
  Misses      13315    13315           
  Partials     1746     1746           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have removed the 1.21 e2e test from the list of checks required to pass.

We should integrate the 1.24 one as a required check (we haven't yet). For future version bumps, please be aware that it requires changes to branch protection rules. So we should only bump patch versions of K3s used for e2e tests when absolutely necessary.

@jannfis jannfis enabled auto-merge (squash) August 12, 2022 21:41
@jannfis jannfis merged commit 6756a5f into argoproj:master Aug 12, 2022
@terrytangyuan terrytangyuan deleted the supported-versions branch August 12, 2022 22:08
@terrytangyuan
Copy link
Member Author

LGTM.

I have removed the 1.21 e2e test from the list of checks required to pass.

We should integrate the 1.24 one as a required check (we haven't yet). For future version bumps, please be aware that it requires changes to branch protection rules. So we should only bump patch versions of K3s used for e2e tests when absolutely necessary.

That makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants