Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore VERSION file for Snyk scan #10363

Merged
merged 1 commit into from Aug 17, 2022

Conversation

OmerKahani
Copy link
Contributor

@OmerKahani OmerKahani commented Aug 17, 2022

Signed-off-by: Omer Kahani 8766193+OmerKahani@users.noreply.github.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

--
part of #8657

The VERSION file might include a version that is pre-release and doesn't have any tag. The suggested change takes the latest tag and ignores the version in the VERSION file.

Currently, the VERSION file has the value of: v2.5.0, which case an error in the original script. The suggested change will perform scan on version: master v2.4.9 v2.3.7 v2.2.12

Signed-off-by: Omer Kahani <8766193+OmerKahani@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #10363 (1bd1015) into master (2d544b4) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10363      +/-   ##
==========================================
+ Coverage   46.16%   46.27%   +0.10%     
==========================================
  Files         228      228              
  Lines       28004    27869     -135     
==========================================
- Hits        12927    12895      -32     
+ Misses      13324    13235      -89     
+ Partials     1753     1739      -14     
Impacted Files Coverage Δ
server/logout/logout.go 77.77% <0.00%> (-6.10%) ⬇️
server/application/application.go 31.86% <0.00%> (-0.27%) ⬇️
pkg/apiclient/apiclient.go 0.96% <0.00%> (+<0.01%) ⬆️
...is/applicationset/v1alpha1/applicationset_types.go 37.93% <0.00%> (+3.23%) ⬆️
util/grpc/useragent.go 56.25% <0.00%> (+10.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crenshaw-dev crenshaw-dev changed the title Chore: Ignore VERSION file for snyk scan chore: Ignore VERSION file for Snyk scan Aug 17, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We bump the version ahead in the master branch. This is a good catch, using using tags is cleaner. Thanks @OmerKahani!

@crenshaw-dev crenshaw-dev merged commit ae4a67a into argoproj:master Aug 17, 2022
@crenshaw-dev
Copy link
Collaborator

@OmerKahani do you expect this change will fix the action failure?

@OmerKahani
Copy link
Contributor Author

Yes, I run it locally

@OmerKahani OmerKahani deleted the patch-2 branch April 9, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants