Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scrollbar to live manifest #10379

Merged
merged 7 commits into from Aug 26, 2022

Conversation

ashutosh16
Copy link
Contributor

@ashutosh16 ashutosh16 commented Aug 18, 2022

Signed-off-by: Ashutosh mail.ashutosh8@gmail.com
fix : #10457
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Ashutosh and others added 3 commits August 17, 2022 15:11
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #10379 (885d74d) into master (a23bfc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10379   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         233      233           
  Lines       28401    28401           
=======================================
  Hits        12998    12998           
  Misses      13629    13629           
  Partials     1774     1774           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashutosh16 ashutosh16 changed the title feat: add scrollbar to livemanifest feat: add scrollbar to live manifest Aug 18, 2022
@ashutosh16
Copy link
Contributor Author

vertical_scrollbar_in_livemanifest

@ashutosh16 ashutosh16 marked this pull request as ready for review August 18, 2022 19:42
@ashutosh16 ashutosh16 marked this pull request as draft August 18, 2022 21:27
@ashutosh16 ashutosh16 marked this pull request as ready for review August 19, 2022 15:27
@ashutosh16
Copy link
Contributor Author

@keithchong Can you review this PR?

@ashutosh16
Copy link
Contributor Author

@rbreeze Would you be able to review and provide your feedback?

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is good, but it doesn't address the issue linked (#9928). Can you remove it from the PR description so the issue doesn't get closed?

@ashutosh16
Copy link
Contributor Author

ashutosh16 commented Aug 26, 2022

@rbreeze thanks for reviewing the PR, I update the description with the correct issue.
fix #10457

@leoluz leoluz merged commit 0936da9 into argoproj:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When modifying the live manifest, a save button should be visible at the top of the page.
3 participants