fix(ui): Fix multi-app refresh and sync in the UI #10421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
Codecov Report
@@ Coverage Diff @@
## master #10421 +/- ##
=======================================
Coverage 45.78% 45.78%
=======================================
Files 233 233
Lines 28383 28383
=======================================
Hits 12995 12995
Misses 13614 13614
Partials 1774 1774 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@jannfis looks like this is missing the namespace, Does this need to fix as well? |
|
Good catch, @ashutosh16. I think there may be even more places throughout the UI's code where this is missing. I'm trying to play catch 'em all, but unfortunately, the UI linter is not very helpful so I need to go full manual :\ Happy for suggestions. |
Signed-off-by: jannfis <jann@mistrust.net>
rbreeze
requested changes
Aug 22, 2022
| @@ -120,7 +120,9 @@ export const ApplicationNodeInfo = (props: { | |||
| <YamlEditor | |||
| input={live} | |||
| hideModeButtons={!live} | |||
| onSave={(patch, patchType) => services.applications.patchResource(props.application.metadata.name, props.node, patch, patchType)} | |||
| onSave={(patch, patchType) => | |||
| services.applications.patchResource(props.application.metadata.name, props.application.metadata.name, props.node, patch, patchType) | |||
There was a problem hiding this comment.
Should second argument to this fxn call be props.application.metadata.namespace?
Signed-off-by: jannfis <jann@mistrust.net>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in the Applications in any namespaces PR.
Signed-off-by: jannfis jann@mistrust.net
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: