Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add reverse proxy proposal for enhanced UI extensions #10435

Merged
merged 19 commits into from Oct 12, 2022
Merged

docs: add reverse proxy proposal for enhanced UI extensions #10435

merged 19 commits into from Oct 12, 2022

Conversation

leoluz
Copy link
Collaborator

@leoluz leoluz commented Aug 23, 2022 •
edited

Signed-off-by: Leonardo Luz Almeida leonardo_almeida@intuit.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@leoluz
docs: add reverse proxy proposal for enhanced UI extensions
837ca51 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited

Codecov Report

Base: 45.76% // Head: 45.62% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (6124913) compared to base (202b69a).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10435      +/-   ##
==========================================
- Coverage   45.76%   45.62%   -0.15%     
==========================================
  Files         233      236       +3     
  Lines       28401    28699     +298     
==========================================
+ Hits        12998    13093      +95     
- Misses      13629    13805     +176     
- Partials     1774     1801      +27
Impacted Files Coverage Δ
util/argo/audit_logger.go 88.00% <0.00%> (-7.66%) ⬇️
util/argo/argo.go 63.45% <0.00%> (-3.40%) ⬇️
util/webhook/webhook.go 65.27% <0.00%> (-3.17%) ⬇️
controller/state.go 72.44% <0.00%> (-1.32%) ⬇️
controller/sync.go 54.05% <0.00%> (-1.29%) ⬇️
reposerver/repository/repository.go 61.11% <0.00%> (-0.85%) ⬇️
server/project/project.go 51.68% <0.00%> (-0.83%) ⬇️
controller/appcontroller.go 51.78% <0.00%> (-0.53%) ⬇️
util/git/client.go 48.64% <0.00%> (-0.53%) ⬇️
cmd/argocd/commands/app.go 18.50% <0.00%> (-0.41%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leoluz
add goals and use-case
409d224 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add CRD example
84d0f18 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add goal details
be92d14 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add rbac use-case
1ef9a72 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add rbac details and examples
f854b13 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add config section
96a8c36 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@sarabala1979
Copy link
Member

Looks good and it covers most use cases. Thanks @leoluz

@leoluz
Add diagrams to the proposal
b42021b 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add considerations
7ca13f3 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Minor fixes
6d161f0 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
minor fixes
55f677e 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
add multi backend support to proxy proposal
4d52b32 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Address review comments + multi-backend details
1793f0d 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
address comments
67912a5 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
crenshaw-dev
crenshaw-dev reviewed Oct 3, 2022
View reviewed changes
docs/proposals/proxy-extensions.md Outdated Show resolved Hide resolved
docs/proposals/proxy-extensions.md Show resolved Hide resolved
docs/proposals/proxy-extensions.md Show resolved Hide resolved
docs/proposals/proxy-extensions.md Show resolved Hide resolved
docs/proposals/proxy-extensions.md Show resolved Hide resolved
docs/proposals/proxy-extensions.md Outdated Show resolved Hide resolved
docs/proposals/proxy-extensions.md Outdated Show resolved Hide resolved
docs/proposals/proxy-extensions.md Outdated Show resolved Hide resolved
docs/proposals/proxy-extensions.md Show resolved Hide resolved
@leoluz
Address review comments
7e5957b 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add additional goal for additional security
25b552b 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Add RBAC suggestions
12487ce 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Minor changes
8d3356d 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
@leoluz
Visual improvement
6124913 
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
crenshaw-dev
crenshaw-dev approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work

@crenshaw-dev crenshaw-dev merged commit c99669e into argoproj:master Oct 12, 2022
nbjohnson pushed a commit to nbjohnson/argo-cd that referenced this pull request Oct 18, 2022
@leoluz @nbjohnson
docs: add reverse proxy proposal for enhanced UI extensions (argoproj…
e62a2b4 
…#10435)

* docs: add reverse proxy proposal for enhanced UI extensions

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* add goals and use-case

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add CRD example

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add goal details

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add rbac use-case

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add rbac details and examples

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add config section

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add diagrams to the proposal

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add considerations

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Minor fixes

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* minor fixes

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* add multi backend support to proxy proposal

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments + multi-backend details

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* address comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add additional goal for additional security

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Add RBAC suggestions

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Minor changes

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

* Visual improvement

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>

Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: Nicholas Johnson <nbjohnson10@gmail.com>
@crenshaw-dev crenshaw-dev mentioned this pull request Jan 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller left review comments

@alexec alexec alexec left review comments

@ashutosh16 ashutosh16 ashutosh16 left review comments

@sarabala1979 sarabala1979 sarabala1979 left review comments

@kmlamkin9 kmlamkin9 kmlamkin9 left review comments

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@leoluz @sarabala1979 @zachaller @crenshaw-dev @alexec @ashutosh16 @kmlamkin9