chore: [util/dex|glob] Add security logging

[my-git9]

[util/dex|glob] Add security logging

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 45.76% // Head: 45.68% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (862349f) compared to base (a23bfc3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10455      +/-   ##
==========================================
- Coverage   45.76%   45.68%   -0.08%     
==========================================
  Files         233      236       +3     
  Lines       28401    28670     +269     
==========================================
+ Hits        12998    13099     +101     
- Misses      13629    13779     +150     
- Partials     1774     1792      +18     

Impacted Files	Coverage Δ
util/dex/dex.go	58.62% <100.00%> (+1.47%)	⬆️
util/argo/audit_logger.go	88.00% <0.00%> (-7.66%)	⬇️
util/argo/argo.go	64.43% <0.00%> (-2.42%)	⬇️
controller/state.go	72.44% <0.00%> (-1.32%)	⬇️
controller/sync.go	54.05% <0.00%> (-1.29%)	⬇️
reposerver/repository/repository.go	61.11% <0.00%> (-0.85%)	⬇️
server/project/project.go	51.68% <0.00%> (-0.83%)	⬇️
controller/appcontroller.go	51.78% <0.00%> (-0.53%)	⬇️
cmd/argocd/commands/login.go	2.17% <0.00%> (-0.08%)	⬇️
server/account/account.go	69.62% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jannfis]

Thanks @my-git9

Can you please elaborate a little on the security impact of these errors, i.e. why should they emit a security log event? Thanks!

[my-git9]

Thanks @my-git9

Can you please elaborate a little on the security impact of these errors, i.e. why should they emit a security log event? Thanks!
Discussions and PRs about security logs are here, please see
#10361 (comment)
#10256

[jannfis]

Yes, thanks, I'm aware of this. I was just wondering how the parts of the code you are adding it to are relevant to emit security logging?

Just trying to understand the reasoning behind this particular change.

[notfromstatefarm]

The dex error I can see being useful for security logging - dex is a wholly security-related service. However, logging any time a glob fails to compile anywhere in our codebase doesn't seem security-related.

[my-git9]

I see, I'll tweak the code a bit

[my-git9]

@notfromstatefarm @jannfis I'm sorry, I don't know enough about security logs. Can you think of this?

[crenshaw-dev]

Thanks @my-git9!