Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: HA manifests: remove hardcoded *-processors overriding any other settings #10458

Merged
merged 1 commit into from Sep 1, 2022

Conversation

nazarewk
Copy link
Contributor

@nazarewk nazarewk commented Aug 26, 2022

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Overview

This PR is a 4 years old zombie code removal

At time the change was introduced (and not revised later on) there were no CM mappings and no envvars handling in the code itself. Those hardcoded values prevent any kind of modifications anywhere else (they have highest priority) as described in slack thread and #2720

Original discussion: https://cloud-native.slack.com/archives/C01TSERG0KZ/p1661436953901989
fixes #2720

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #10458 (a4bbf8d) into master (a23bfc3) will not change coverage.
The diff coverage is 53.94%.

@@           Coverage Diff           @@
##           master   #10458   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         233      234    +1     
  Lines       28401    28460   +59     
=======================================
+ Hits        12998    13025   +27     
- Misses      13629    13658   +29     
- Partials     1774     1777    +3     
Impacted Files Coverage Δ
cmd/argocd/commands/admin/notifications.go 0.00% <0.00%> (ø)
pkg/apiclient/apiclient.go 0.94% <0.00%> (-0.03%) ⬇️
server/notification/notification.go 56.00% <56.00%> (ø)
server/server.go 52.49% <100.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nazarewk nazarewk changed the title drop hardcoded processors from HA manifests HA manifests: remove hardcoded *-processors overriding any other settings Aug 29, 2022
@jannfis
Copy link
Member

jannfis commented Aug 29, 2022

Thanks @nazarewk, this change absolutely makes sense.

Please run make manifests (or make manifests-local, considering you have Kustomize and Helm installed in similar versions to what's expected by Argo CD) to satisfy the codegen check.

Signed-off-by: Krzysztof Nazarewski <3494992+nazarewk@users.noreply.github.com>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jannfis jannfis changed the title HA manifests: remove hardcoded *-processors overriding any other settings chore: HA manifests: remove hardcoded *-processors overriding any other settings Sep 1, 2022
@jannfis jannfis merged commit 75313e0 into argoproj:master Sep 1, 2022
@nazarewk nazarewk deleted the patch-1 branch September 1, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Override status and operation processors using kustomize
2 participants