feat: add the ability to filter apps based on clusters #10465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test result: $ ./dist/argocd app list -c https://10.29.8.20:16443
NAME CLUSTER NAMESPACE PROJECT STATUS HEALTH SYNCPOLICY CONDITIONS REPO PATH TARGET
argocd/guestbookproj https://10.29.8.20:16443 kube-public test OutOfSync Healthy <none> SharedResourceWarning(2) https://gitlab.daocloud.cn/xin.li/argocd-example.git guestbook
$
$ ./dist/argocd app list --cluster https://kubernetes.default.svc
NAME CLUSTER NAMESPACE PROJECT STATUS HEALTH SYNCPOLICY CONDITIONS REPO PATH TARGET
argocd/apps https://kubernetes.default.svc default default OutOfSync Progressing <none> <none> https://gitlab.daocloud.cn/xin.li/argocd-example.git apps HEAD
argocd/guestbook https://kubernetes.default.svc default default Synced Healthy Auto <none> https://gitlab.daocloud.cn/xin.li/argocd-example.git guestbook HEAD
argocd/guestbook-helm https://kubernetes.default.svc default default Synced Healthy <none> <none> https://gitlab.daocloud.cn/xin.li/argocd-example.git helm-guestbook HEAD
argocd/guestbook-pub https://kubernetes.default.svc kube-public default Synced Healthy <none> <none> https://gitlab.daocloud.cn/xin.li/argocd-example.git guestbook
argocd/test https://kubernetes.default.svc default default Synced Healthy <none> <none> https://gitlab.daocloud.cn/xin.li/argocd-example.git helm-hooks
|
Codecov Report
@@ Coverage Diff @@
## master #10465 +/- ##
==========================================
- Coverage 45.78% 45.67% -0.11%
==========================================
Files 233 234 +1
Lines 28383 28518 +135
==========================================
+ Hits 12995 13027 +32
- Misses 13614 13704 +90
- Partials 1774 1787 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
my-git9
force-pushed
the
appcluster
branch
3 times, most recently
from
ca2545e
to
1d57e8a
Compare
|
Hi @jannfis, Can you review this PR? Thanks |
ashutosh16
reviewed
Aug 29, 2022
5 tasks
crenshaw-dev
requested changes
Sep 9, 2022
cmd/argocd/commands/app.go
Outdated
| @@ -1293,6 +1296,7 @@ func NewApplicationListCommand(clientOpts *argocdclient.ClientOptions) *cobra.Co | |||
| command.Flags().StringArrayVarP(&projects, "project", "p", []string{}, "Filter by project name") | |||
| command.Flags().StringVarP(&repo, "repo", "r", "", "List apps by source repo URL") | |||
| command.Flags().StringVarP(&appNamespace, "app-namespace", "N", "", "Only list applications in namespace") | |||
| command.Flags().StringVarP(&cluster, "cluster", "c", "", "List apps by cluster") | |||
There was a problem hiding this comment.
Thanks for this @my-git9! Can you update this string to clarify that either a URL or cluster name is acceptable?
There was a problem hiding this comment.
Updated.Do you think this is ok?
Signed-off-by: xin.li <xin.li@daocloud.io>
my-git9
requested review from
crenshaw-dev and
ashutosh16
and removed request for
crenshaw-dev and
ashutosh16
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to filter apps based on clusters
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: