New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Prometheus health check #10508
Merged
crenshaw-dev
merged 3 commits into
argoproj:master
from
roelvdberg:health-check-prometheus
Sep 30, 2022
Merged
feat: add Prometheus health check #10508
crenshaw-dev
merged 3 commits into
argoproj:master
from
roelvdberg:health-check-prometheus
Sep 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com>
Codecov Report
@@ Coverage Diff @@
## master #10508 +/- ##
=======================================
Coverage 45.69% 45.69%
=======================================
Files 234 234
Lines 28508 28508
=======================================
Hits 13027 13027
Misses 13694 13694
Partials 1787 1787
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
resource_customizations/monitoring.coreos.com/Prometheus/testdata/degraded.yaml
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/degraded.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/degraded.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/degraded.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/degraded.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/healthy.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/progressing.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/progressing.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/progressing.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/progressing.yaml
Outdated
Show resolved
Hide resolved
resource_customizations/monitoring.coreos.com/Prometheus/testdata/progressing.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Rouke Broersma <mobrockers@gmail.com> Signed-off-by: roelvdberg <email@roelvdberg.nl>
crenshaw-dev
changed the title
Create Prometheus health check
feat: add Prometheus health check
Sep 9, 2022
crenshaw-dev
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @roelvdberg!
ashutosh16
pushed a commit
to ashutosh16/argo-cd
that referenced
this pull request
Oct 7, 2022
* Create Prometheus health check Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com> * remove details from our test environment Co-authored-by: Rouke Broersma <mobrockers@gmail.com> Signed-off-by: roelvdberg <email@roelvdberg.nl> Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com> Signed-off-by: roelvdberg <email@roelvdberg.nl> Co-authored-by: Roel van den Berg <roel.vandenberg@infosupport.com> Co-authored-by: Rouke Broersma <mobrockers@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implements healths check for monitoring.coreos.com/Prometheus