Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Prometheus health check #10508

Merged
merged 3 commits into from Sep 30, 2022
Merged

feat: add Prometheus health check #10508

merged 3 commits into from Sep 30, 2022

Conversation

roelvdberg
Copy link
Contributor

PR implements healths check for monitoring.coreos.com/Prometheus

Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com>
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #10508 (f6650a7) into master (5f3fc68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10508   +/-   ##
=======================================
  Coverage   45.69%   45.69%           
=======================================
  Files         234      234           
  Lines       28508    28508           
=======================================
  Hits        13027    13027           
  Misses      13694    13694           
  Partials     1787     1787           
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

roelvdberg and others added 2 commits September 5, 2022 09:51
Co-authored-by: Rouke Broersma <mobrockers@gmail.com>
Signed-off-by: roelvdberg <email@roelvdberg.nl>
@crenshaw-dev crenshaw-dev changed the title Create Prometheus health check feat: add Prometheus health check Sep 9, 2022
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @roelvdberg!

@crenshaw-dev crenshaw-dev merged commit 8a38b8b into argoproj:master Sep 30, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Oct 7, 2022
* Create Prometheus health check

Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com>

* remove details from our test environment

Co-authored-by: Rouke Broersma <mobrockers@gmail.com>
Signed-off-by: roelvdberg <email@roelvdberg.nl>

Signed-off-by: Roel van den Berg <roel.vandenberg@infosupport.com>
Signed-off-by: roelvdberg <email@roelvdberg.nl>
Co-authored-by: Roel van den Berg <roel.vandenberg@infosupport.com>
Co-authored-by: Rouke Broersma <mobrockers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants